Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter326: init at 3.26.0-0.1pre #347124

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

RossComputerGuy
Copy link
Member

Things done

New prerelease Flutter, need it for some work I'm doing that relies on this engine PR flutter/engine#54575.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@FlafyDev
Copy link
Contributor

FlafyDev commented Oct 7, 2024

would flutter (flutterPackages.stable) now point to v3.26 ? Is it possible to keep it on the stable version v3.24 until v3.26 fully releases?

@RossComputerGuy
Copy link
Member Author

No, it should be pointing to beta because we fetched it under the beta channel.

@FlafyDev
Copy link
Contributor

FlafyDev commented Oct 7, 2024

No, it should be pointing to beta because we fetched it under the beta channel.

oh awesome

I tried using flutter326 but can't create a project or build anything. is this an issue?

❯ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[!] Flutter (Channel [user-branch], 0.0.0-unknown, on NixOS 24.11 (Vicuna) 6.6.52, locale en_IL)
    ! Flutter version 0.0.0-unknown on channel [user-branch] at
      /nix/store/8wjfnk3yggfhq8agys9hbg4r771qf18w-flutter-wrapped-3.26.0-0.1.pre-sdk-links
(...)
❯ flutter build linux --release
Resolving dependencies... 
Note: leak_tracker_flutter_testing is pinned to version 3.0.8 by flutter_test from the flutter SDK.
See https://dart.dev/go/sdk-version-pinning for details.

The current Flutter SDK version is 0.0.0-unknown.

Because every version of flutter_test from sdk depends on leak_tracker_flutter_testing >=2.0.3 which requires
  Flutter SDK version >=3.18.0-18.0.pre.54, flutter_test from sdk is forbidden.
So, because fluttertestproj depends on flutter_test from sdk, version solving failed.


You can try the following suggestion to make the pubspec resolve:
* Try using the Flutter SDK version: 3.24.3. 
Failed to update packages.

seems like it doesn't know the version of the sdk so it can't resolve dependencies

@RossComputerGuy
Copy link
Member Author

I haven't gotten a chance to test it so that seems like an issue

@RossComputerGuy
Copy link
Member Author

The version JSON file gets messed up in the wrapper.

@RossComputerGuy
Copy link
Member Author

Ok, this should work now that the version file isn't being used from the prepared artifacts.

@RossComputerGuy
Copy link
Member Author

Tested this and it works, artifact hashes got messed up so I'll fix those.

Copy link
Contributor

@FlafyDev FlafyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

can't really nixpkgs-review rn because of limited storage. but I tried relevant packages and everything seems to work 👍

@RossComputerGuy
Copy link
Member Author

Well, we'll just merge and see what happens.

@RossComputerGuy RossComputerGuy merged commit 25e734d into NixOS:master Oct 12, 2024
26 checks passed
@RossComputerGuy RossComputerGuy deleted the feat/flutter-3-26-pre branch October 12, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants