-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flutter326: init at 3.26.0-0.1pre #347124
Conversation
would |
No, it should be pointing to beta because we fetched it under the beta channel. |
oh awesome I tried using
seems like it doesn't know the version of the sdk so it can't resolve dependencies |
I haven't gotten a chance to test it so that seems like an issue |
The version JSON file gets messed up in the wrapper. |
3738df8
to
4f1935a
Compare
Ok, this should work now that the version file isn't being used from the prepared artifacts. |
Tested this and it works, artifact hashes got messed up so I'll fix those. |
4f1935a
to
9d5adb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
can't really nixpkgs-review rn because of limited storage. but I tried relevant packages and everything seems to work 👍
Well, we'll just merge and see what happens. |
Things done
New prerelease Flutter, need it for some work I'm doing that relies on this engine PR flutter/engine#54575.
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.