Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playwright-driver: fix eval on Nix 2.3 #347114

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

philiptaron
Copy link
Contributor

@philiptaron philiptaron commented Oct 7, 2024

Motivation for changes

Fix evaluation on nixVersions.minimum (Nix 2.3) so that nixpkgs-vet is able to work on all versions of Nix that are supported in nixpkgs.

This was detected with nixpkgs-vet's automated update: NixOS/nixpkgs-vet#114

Description of changes

Nix 2.3 doesn't support the ./${name}.nix syntax that #298944 uses. Instead, it uses the clunkier ./. + "/${name}.nix" syntax.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Oct 7, 2024

In this case we can probably make an exception, but eventually I don't think we should hold back using newer features if they benefit in nixpkgs.

@philiptaron
Copy link
Contributor Author

philiptaron commented Oct 7, 2024

In this case we can probably make an exception, but eventually I don't think we should hold back using newer features if they benefit in nixpkgs.

It's shocking how few new features are accidentally used -- the backwards compatibility is quite good, massive kudos to the Nix and Lix teams for this. The last PR of this sort was #329212 in July, and just like this one, was trivial to spot and remediate.

The day will obviously come when nixVersions.minimum is raised to some newer version of Nix. Before that, let's keep the compatibility, especially if it doesn't have a big maintenance burden -- which, based on the evidence and the Nixpkgs-wide test that nixpkgs-vet uses, is quite low!

Copy link
Member

@phaer phaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching & fixing :)

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 7, 2024
@philiptaron philiptaron merged commit 36dd24b into NixOS:master Oct 7, 2024
20 of 22 checks passed
@philiptaron philiptaron deleted the nix-2.3-eval-fixes branch October 7, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants