Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{flexcpp, bisoncpp}: adopt and update #347109

Closed
wants to merge 11 commits into from
Closed

{flexcpp, bisoncpp}: adopt and update #347109

wants to merge 11 commits into from

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Oct 7, 2024 •
edited
Loading

Closes #347051

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres AndersonTorres marked this pull request as ready for review October 7, 2024 15:18
@AndersonTorres AndersonTorres marked this pull request as draft October 7, 2024 15:20
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Oct 7, 2024
@ofborg ofborg bot requested a review from 7c6f434c October 7, 2024 17:02
@AndersonTorres AndersonTorres force-pushed the adopt-flexcpp branch 2 times, most recently from dd186a6 to e5fffd8 Compare October 7, 2024 19:24
@AndersonTorres AndersonTorres changed the title flexcpp: adopt and update {flexcpp, bisoncpp}: adopt and update Oct 7, 2024
@ofborg ofborg bot requested a review from pSub October 7, 2024 23:39
@AndersonTorres
Copy link
Member Author

AndersonTorres commented Oct 8, 2024 •
edited
Loading

Newest icmake needs gcc 14 (std c++26). Let's retry.

Edit: the most recent does not build.

@rennsax rennsax self-assigned this Oct 8, 2024
@AndersonTorres AndersonTorres force-pushed the adopt-flexcpp branch 4 times, most recently from a491a02 to 6f72148 Compare October 9, 2024 20:04
@AndersonTorres AndersonTorres marked this pull request as ready for review October 9, 2024 20:05
@AndersonTorres AndersonTorres marked this pull request as draft October 9, 2024 20:58
@AndersonTorres
Copy link
Member Author

AndersonTorres commented Oct 9, 2024 •
edited
Loading

I will try to run the review first, then merge everything.

P.S.: It worked! However I can't update it to newer versions for bobcat and icmake.

@AndersonTorres AndersonTorres marked this pull request as ready for review October 9, 2024 23:42
@AndersonTorres
yodl: refactor
4751325 
- nixfmt-rfc-style
- finalAttrs
- strictDeps
- hammer
- no nested with
- more meta attrs
@AndersonTorres
flexcpp: migrate to by-name
a45e9b8
@AndersonTorres
flexcpp: 2.05.00 -> 2.16.00
ec21d0e
@AndersonTorres
flexcpp: test bisoncpp
3e6397a 
As a reverse dependency.
@AndersonTorres
bisoncpp: migrate to by-name
7242ec5
@AndersonTorres
bisoncpp: refactor
712a2bf 
- factor gpl license reference
- nixfmt-rfc-style
- hammer
- finalAttrs
- strictDeps
- runHooks
- no nested with
@AndersonTorres
bisoncpp: 6.04.00 -> 6.09.00
8b29c72
@AndersonTorres
icmake: migrate to by-name
7b129f2
@AndersonTorres
icmake: refactor
5deaa11 
- nixfmt-rfc-style
- finalAttrs
- strictDeps
- hammer
- no nested with
- more meta attrs
@AndersonTorres
bobcat: refactor
0e6fa10 
- finalAttrs
- hammer
- nixfmt-rfc-style
- adoption
7c6f434c
7c6f434c approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

rennsax
rennsax approved these changes Oct 11, 2024
View reviewed changes
pkgs/by-name/fl/flexcpp/package.nix
@@ -0,0 +1,99 @@
{
lib,
bisoncpp,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused about this "recursive dependency" 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I figured out, thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 61.
This is a more or less typical design pattern: we tests reverse dependencies so that we can guarrantee that e.g. updating flexcpp does not break existing bisoncpp.

You can see a similar thing at live555.

@7c6f434c
Copy link
Member

Hmm, a part of that is GCC-only upstream?

@AndersonTorres
Copy link
Member Author

Hmm, a part of that is GCC-only upstream?

Yes, mostly because it hardcodes gcc all around...

@7c6f434c
Copy link
Member

Should we mark it Darwin-unsupported then?

@AndersonTorres
Copy link
Member Author

Given that I can't care for Darwin, maybe yes.

@rennsax
Copy link
Member

rennsax commented Oct 15, 2024 •
edited
Loading

@AndersonTorres I can test for Darwin later (it's important for me, frankly speaking 🥺), would you mind keep this PR opened for some time?

@AndersonTorres
Copy link
Member Author

Yep.

@7c6f434c
Copy link
Member

@rennsax Note that ofBorg reports build failures there so some fixing will be needed

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 15, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024
@rennsax
Copy link
Member

rennsax commented Nov 12, 2024

I gave up 😭 Sorry for that. I found it requires much work and the upstream has abundant portability problems. And I think it's inappropriate for us to ship with so many patches for bobcat. The author's library is only used by himself.

@rennsax
Copy link
Member

rennsax commented Nov 12, 2024

Darwin support should be removed for all these stuff.

@tomberek
Copy link
Contributor

@7c6f434c @AndersonTorres is this good to merge soon?

@AndersonTorres
Copy link
Member Author

Nein.

@AndersonTorres AndersonTorres deleted the adopt-flexcpp branch December 14, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rennsax rennsax rennsax approved these changes

@7c6f434c 7c6f434c 7c6f434c approved these changes

@pSub pSub Awaiting requested review from pSub

Assignees

@rennsax rennsax

Labels
2.status: merge conflict This PR has merge conflicts with the target branch 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update request: flexcpp 2.05.00 → 2.16.00
5 participants
@AndersonTorres @7c6f434c @rennsax @tomberek @wegank