hello: make sure libiconv is linked #346939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 tasks
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 0
emilazy
requested changes
Oct 7, 2024
reckenrode
changed the base branch from
master
to
reckenrode/darwin-sdk-refactor
reckenrode
force-pushed
the
push-umprpqvmsktr
branch
from
7b1138e to
3d68317
Compare
ofborg
bot
added
2.status: merge conflict
reckenrode
force-pushed
the
push-umprpqvmsktr
branch
from
3d68317 to
d2da470
Compare
github-actions
bot
added
6.topic: python
6.topic: nixos
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
2 times, most recently
from
183877a to
1fd30e4
Compare
reckenrode
force-pushed
the
push-umprpqvmsktr
branch
from
d2da470 to
e27687a
Compare
github-actions
bot
removed
8.has: changelog
8.has: module (update)
reckenrode
force-pushed
the
push-umprpqvmsktr
branch
from
e27687a to
9aefbb8
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
2 times, most recently
from
a240201 to
4112f1a
Compare
Because the Darwin SDK automatically propagates libiconv, it is no longer linked automatically (because that would link libiconv to everything whether it wanted it or not). hello is failing to link not because it assumes libiconv comes with libc but because of a bug in its build system. The `configure` script detects how to link libiconv, but `Makefile.am` does not make use of that to link libiconv when it is needed. Unfortunately, patching `Makefile.am` can’t be done because using `autoreconfHook` will update some gettext stuff with an incompatible version, causing an error when building.
reckenrode
force-pushed
the
push-umprpqvmsktr
branch
from
9aefbb8 to
42a6b87
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
2 times, most recently
from
a1adff0 to
e3f2829
Compare
emilazy
changed the base branch from
reckenrode/darwin-sdk-refactor
to
staging
emilazy
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the Darwin SDK after #346043 will automatically propagate libiconv, it is no longer linked automatically (because that would link libiconv to everything whether it wanted it or not).
hello is failing to link not because it assumes libiconv comes with libc but because of a bug in its build system. The
configurescript detects how to link libiconv, butMakefile.amdoes not make use of that to link libiconv when it is needed.Unfortunately, patching
Makefile.amcan’t be done because usingautoreconfHookwill update some gettext stuff with an incompatible version, causing an error when building.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.