python3Packages.materialx: enable MSL support on x86_64-darwin #346930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 tasks
emilazy
reviewed
Oct 6, 2024
| (lib.cmakeBool "MATERIALX_BUILD_GEN_MSL" ( | ||
| stdenv.hostPlatform.isLinux || (stdenv.hostPlatform.isAarch64 && stdenv.hostPlatform.isDarwin) | ||
| )) | ||
| (lib.cmakeBool "MATERIALX_BUILD_GEN_MSL" stdenv.hostPlatform.isLinux) |
There was a problem hiding this comment.
This should be || stdenv.hostPlatform.isDarwin, right?
There was a problem hiding this comment.
Should be fixed now.
reckenrode
force-pushed
the
push-vrxwtvsttrvy
branch
from
f787b64 to
972edeb
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 0
reckenrode
force-pushed
the
push-vrxwtvsttrvy
branch
from
972edeb to
73593b6
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
from
ee7fb7e to
183877a
Compare
reckenrode
force-pushed
the
push-vrxwtvsttrvy
branch
from
73593b6 to
675acd4
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
from
183877a to
1fd30e4
Compare
reckenrode
force-pushed
the
push-vrxwtvsttrvy
branch
2 times, most recently
from
7a9a46a to
c03e6ca
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
2 times, most recently
from
a240201 to
4112f1a
Compare
reckenrode
force-pushed
the
push-vrxwtvsttrvy
branch
from
c03e6ca to
088dce9
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
2 times, most recently
from
a1adff0 to
e3f2829
Compare
reckenrode
changed the base branch from
reckenrode/darwin-sdk-refactor
to
staging
emilazy
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #346043, it is possible to enable MSL support on x86_64-darwin. The 10.15 deployment target is based on upstream’s README, which states 10.15.7 is the oldest tested version.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.