-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coroot-node-agent: init at 1.22.2 #346845
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4652 |
c7a8c2b
to
d1f7023
Compare
Changed repo name to hardcoded string as it was suggested to be more idiomatic in |
d1f7023
to
1d64172
Compare
removed |
1d64172
to
9788fca
Compare
added |
9788fca
to
9430000
Compare
updated to latest release |
9430000
to
f543565
Compare
Thanks for the review @FliegendeWurst ! I've removed the empty block from the package definition and bumped version to latest release while at it. There's also a response to the location related discussion explaining some of the reasoning for that. |
Adding package for coroot-node-agent. It's the data-collector service for
coroot
server that is added in PR #346844.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.