Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coroot-node-agent: init at 1.22.2 #346845

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

errnoh
Copy link
Contributor

@errnoh errnoh commented Oct 6, 2024

Adding package for coroot-node-agent. It's the data-collector service for coroot server that is added in PR #346844.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4652

@errnoh errnoh force-pushed the add-coroot-node-agent branch from c7a8c2b to d1f7023 Compare October 7, 2024 18:42
@errnoh
Copy link
Contributor Author

errnoh commented Oct 7, 2024

Changed repo name to hardcoded string as it was suggested to be more idiomatic in coroot PR review.

@errnoh errnoh force-pushed the add-coroot-node-agent branch from d1f7023 to 1d64172 Compare October 9, 2024 18:35
@errnoh
Copy link
Contributor Author

errnoh commented Oct 9, 2024

removed with lib from the meta block

@errnoh errnoh force-pushed the add-coroot-node-agent branch from 1d64172 to 9788fca Compare October 15, 2024 21:24
@errnoh
Copy link
Contributor Author

errnoh commented Oct 15, 2024

added meta.mainProgram

@errnoh errnoh force-pushed the add-coroot-node-agent branch from 9788fca to 9430000 Compare October 30, 2024 20:38
@errnoh errnoh changed the title coroot-node-agent: init at 1.21.7 coroot-node-agent: init at 1.21.9 Oct 30, 2024
@errnoh
Copy link
Contributor Author

errnoh commented Oct 30, 2024

updated to latest release

@errnoh errnoh force-pushed the add-coroot-node-agent branch from 9430000 to f543565 Compare November 15, 2024 16:05
@errnoh errnoh changed the title coroot-node-agent: init at 1.21.9 coroot-node-agent: init at 1.22.2 Nov 15, 2024
@errnoh
Copy link
Contributor Author

errnoh commented Nov 15, 2024

Thanks for the review @FliegendeWurst ! I've removed the empty block from the package definition and bumped version to latest release while at it. There's also a response to the location related discussion explaining some of the reasoning for that.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 17, 2024
@FliegendeWurst FliegendeWurst merged commit a064ed0 into NixOS:master Dec 20, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants