lib.modules: fix test line using empty "$@" #346677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably a missed left over from somewhere in the commit 58f385f. As can be seen in that commit where this line was introduced, "$@" was also just emptied by the last `set` call in line 169. This line is currently valid, but breaks suddenly when somewhere earlier a `set --` instruction is used in the future. Neither in commit 58f385f nor in PR NixOS#197547 have I found anything stating that this "defect" was intentional.
github-actions
bot
added
6.topic: module system
ofborg
bot
added
10.rebuild-darwin: 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Probably a missed left over from somewhere in
the commit 58f385f. As can be seen in that commit where this line was introduced, "$@" was also just emptied by the last
setcall in line 169. This line is currently valid, but breaks suddenly when somewhere earlier aset --instruction is used in the future.Neither in commit 58f385f nor in PR #197547 have I found anything stating that this "defect" was intentional.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)For testing I executed
nix-build lib/tests/release.nix.Add a 👍 reaction to pull requests you find important.