Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

valkey: 7.2.6 -> 7.2.7 #346200

Merged
merged 1 commit into from
Oct 4, 2024
Merged

valkey: 7.2.6 -> 7.2.7 #346200

merged 1 commit into from
Oct 4, 2024

Conversation

MarcelCoding
Copy link
Member

fixes CVE-2024-31449, CVE-2024-31227, CVE-2024-31228

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@MarcelCoding MarcelCoding added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-24.05 labels Oct 3, 2024
@ofborg ofborg bot requested a review from Rucadi October 3, 2024 18:06
SuperSandro2000
SuperSandro2000 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixes format should be

Fixes CVE-2024-31449
Fixes CVE-2024-31227
Fixes CVE-2024-31228

@MarcelCoding
valkey: 7.2.6 -> 7.2.7
85ab36b 
Fixes CVE-2024-31449
Fixes CVE-2024-31227
Fixes CVE-2024-31228
@SuperSandro2000 SuperSandro2000 merged commit 9975800 into NixOS:master Oct 4, 2024
26 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-346200-to-release-24.05 origin/release-24.05
cd .worktree/backport-346200-to-release-24.05
git switch --create backport-346200-to-release-24.05
git cherry-pick -x 85ab36bb84152ff154f5d9a0b05a8bc8b3d6c2f9

@MarcelCoding MarcelCoding deleted the valkey branch October 4, 2024 05:22
@MarcelCoding
Copy link
Member Author

Backported PR: #346434

@MarcelCoding MarcelCoding mentioned this pull request Oct 4, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@Rucadi Rucadi Awaiting requested review from Rucadi

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcelCoding @SuperSandro2000