Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave: 1.70.119 -> 1.70.123 #346015

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Oct 2, 2024

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for brave is: Privacy-oriented browser for Desktop and Laptop computers

meta.homepage for brave is: https://brave.com/

meta.changelog for brave is: https://github.com/brave/brave-browser/blob/master/CHANGELOG_DESKTOP.md#170123

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.70.123 with grep in /nix/store/kxc0545dfj9q0z20zp6c0qawillkl1r7-brave-1.70.123
  • found 1.70.123 in filename of file in /nix/store/kxc0545dfj9q0z20zp6c0qawillkl1r7-brave-1.70.123

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

brave
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/kxc0545dfj9q0z20zp6c0qawillkl1r7-brave-1.70.123 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A brave https://github.com/r-ryantm/nixpkgs/archive/07196b859d851803a7393dc2283146ea41a18cf8.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/07196b859d851803a7393dc2283146ea41a18cf8#brave

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/kxc0545dfj9q0z20zp6c0qawillkl1r7-brave-1.70.123
ls -la /nix/store/kxc0545dfj9q0z20zp6c0qawillkl1r7-brave-1.70.123/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • brave

Maintainer pings

cc @uskudnik @rht @JeffLabonte @nasirhm @buckley310 for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 3, 2024
@buckley310 buckley310 added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-24.05 labels Oct 4, 2024
@buckley310
Copy link
Contributor

LGTM. No issues so far browsing with it.

@natsukium natsukium merged commit 16ab9ff into NixOS:master Oct 4, 2024
31 checks passed
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Successfully created backport PR for release-24.05:

@r-ryantm r-ryantm deleted the auto-update/brave branch October 5, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants