Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropbox: add libGL to the FHS environment #345885

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

goffrie
Copy link
Contributor

@goffrie goffrie commented Oct 2, 2024

Adds libGL.so.1 to the environment, as dropbox v209 has stopped shipping libGL.so which otherwise causes a crash on startup if $DISPLAY is set.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from ttuegel October 2, 2024 10:15
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 2, 2024
@goffrie goffrie changed the title dropbox: add libglvnd to the FHS environment dropbox: add libGL to the FHS environment Oct 2, 2024
@denibertovic
Copy link

This solved an issue I was having with dropbox updating itself to 209.4.3661 and then crashing.

Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits.

dropbox v209 has stopped shipping libGL.so, which causes a crash on startup if it's missing and $DISPLAY is set.
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/dropbox-stopped-working/53942/10

@NickCao NickCao merged commit bc33d7e into NixOS:master Oct 11, 2024
26 checks passed
@goffrie goffrie deleted the dropbox-libgl branch October 15, 2024 07:44
denibertovic added a commit to denibertovic/dotfiles that referenced this pull request Nov 22, 2024
NixOS/nixpkgs#345885

This seems to help and prevents the crashloop after dropbox updates
itself from 206.3.6386 to 209.4.3661.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants