Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluxcd: 2.3.0 -> 2.4.0 #345690

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Conversation

superherointj
Copy link
Contributor

@superherointj superherointj commented Oct 1, 2024

To test update script, delete information:

image

And execute: pkgs/by-name/fl/fluxcd/update.sh

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@superherointj superherointj changed the title fluxcd 2.3.0 -> 2.4.0 fluxcd: 2.3.0 -> 2.4.0 Oct 1, 2024
@superherointj superherointj marked this pull request as draft October 1, 2024 11:59
@superherointj
Copy link
Contributor Author

In case you don't mind reviewing. Application is good to go AFAIK.

CC @Aleksanaa @nbraud

@techknowlogick
Copy link
Member

Result of nixpkgs-review pr 345690 run on aarch64-darwin 1

1 package built:
  • fluxcd

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 4, 2024
@superherointj
Copy link
Contributor Author

ping @marcusramberg

@marcusramberg
Copy link
Contributor

Result of nixpkgs-review pr 345690 run on aarch64-linux 1

1 package built:
  • fluxcd

@marcusramberg marcusramberg merged commit b755388 into NixOS:master Oct 9, 2024
39 of 40 checks passed
@superherointj superherointj deleted the package-fluxcd-2.4.0 branch October 9, 2024 08:27
@superherointj
Copy link
Contributor Author

Thanks. Sorry for giving you extra work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants