-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ollama: only set updateScript
for ollama
, not ollama-{rocm,cuda}
#345375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine. Could also compare pname != "ollama"
as the others are renamed.
Nixpkgs-update supports a skiplist: https://github.com/nix-community/nixpkgs-update/blob/d55f27272f33975d67b13be9fa241cdea297dfb1/src/Skiplist.hs#L47 |
@mweinelt Thank you for letting me know. So, to be clear, I should create a pull request on that repository to add |
If the only thing you worry about is r-ryantm, then yes. |
Diff lgtm, but the alternative solution proposed here might seem a better idea. |
Are there any bots other than r-ryantm that might be a problem? If this PR may help, it seems better to merge this as well as adding |
nix-community/nixpkgs-update#446 has been merged |
Description of changes
Attempt to prevent
passthru.updateScript
from triggering a bot update ofollama-rocm
andollama-cuda
. Sinceollama
,ollama-rocm
, andollama-cuda
are all defined in the same file (only specialized with arguments/overrides), onlyollama
should be explicitly updated.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.