-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ncurses6: 20171125 -> 6.1 #34477
ncurses6: 20171125 -> 6.1 #34477
Conversation
@GrahamcOfBorg build ncurses6 vim |
Success on x86_64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
(Darwin failure seems rather unrelated AFAICT) |
@GrahamcOfBorg build ncurses6 vim |
Success on aarch64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
@GrahamcOfBorg build ncurses6 vim |
Success on aarch64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
@GrahamcOfBorg build ncurses6 htop |
Success on x86_64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
repology stats on 6.1 adoption elsewhere: https://repology.org/metapackage/ncurses/information |
8e0f676
to
5ed0dab
Compare
Updated and rebased to resolve conflicts (after ncurses change to always use ncurses6 source but with different ABI's). |
Success on x86_64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Oh, interesting. Do you happen to know this build failure could be avoided with that? (It started happening ever since I couldn't figure how to get ncurses5 compiling on gcc7 and switched to "--with-abi-version=5" instead on the gcc-7 branch).
|
Anyway, assuming that it works on Darwin, sounds good to me. I think this is just hitting ofborg timeouts, so could e.g. @LnL7 take a look of this on Darwin? |
Yes! rogue is the one I remember, there was another but I don't remember. From a random local patch:
also: https://trac.macports.org/ticket/54171 . Oh hey, the other one was "squishyball". Not sure if needed on current nixpkgs. See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=860334 |
re:squishyball, I remember now how I managed to not send that upstream. Here's a rebased branch with the fixes: https://github.com/dtzWill/nixpkgs/tree/fix/squishyball However the patch URL's are from a reworked debian-patches script..... and even so are likely unstable :(. Anyway just sharing in case someone comes looking for whatever it was I was referring to :). |
Fixes build after commit 3d24ae9: https://hydra.nixos.org/build/69789236 Thanks to dtzWill for the pointer: #34477 (comment)
Fixes build after commit 3d24ae9: 3d24ae9#commitcomment-27714305 Thanks to dtzWill for the pointer: #34477 (comment)
From my experience on slightly older tree, a few *old* programs incorrectly rely on ncurses internal details and may now require setting NCURSES_INTERNALS=1 to allow this badness. Since this is release, we can grab it from gnu mirrors.
94ddff0
to
be6e6d2
Compare
Success on aarch64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
#34477 https://bugs.debian.org/860334 (cherry picked from commit ce37526)
Release notes are currently available here: https://www.gnu.org/software/ncurses/#h2-release-notes
(that URL is not future-proof, for what it's worth).
More verbose changelog:
https://invisible-island.net/ncurses/NEWS.html#t20180127
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)From my experience on slightly older tree,
a few old programs incorrectly rely on ncurses internal details
and may now require setting NCURSES_INTERNAL=1 to allow this badness.