-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: tmpfiles.rules -> tmpfiles.settings #343796
base: master
Are you sure you want to change the base?
Conversation
I don’t consider this an improvement so will not approve, but won’t argue or block it as you’ve already done a batch of these. |
That's okay :) The main improvement I see with this API, is that the end user can reach for an entry and edit it through the module system, if they encounter an error or unexpected/opinionated setup. Of course with a recommendation that they report an issue to nixpkgs, but without needing to mess around with |
931cfd4
to
8d4e84a
Compare
Fwiw I have a hard time considering this an improvement as long as #295872 isn't fixed. |
@Ma27 I'm not sure I fully understand your reasoning. Is it because more widespread of I still think using attrs is an improvement due to ease of overriding and being able to address the option values. But I'd also be okay with drafting until the |
OK context was that the change was suggested to be in line with the PR. |
Description of changes
This PR rewrites the tmpfile rules to use the structured attrs variant of the tmpfiles option, for a chunk of nixos modules. The change should not have any functional effect.
Continuation #280373
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.