Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ember-cli: remove mkYarnPackage usage #342153

Merged
merged 1 commit into from
Nov 3, 2024
Merged

ember-cli: remove mkYarnPackage usage #342153

merged 1 commit into from
Nov 3, 2024

Conversation

TomaSajt
Copy link
Contributor

Description of changes

Tracking issue: #324246

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@TomaSajt TomaSajt marked this pull request as draft September 15, 2024 21:50
@TomaSajt TomaSajt mentioned this pull request Sep 15, 2024
Closed
@dotlambda
Copy link
Member

What's mkYarnDeps?

@TomaSajt
Copy link
Contributor Author

TomaSajt commented Sep 15, 2024 •
edited
Loading

What's mkYarnDeps?

fixed, thanks

@TomaSajt TomaSajt changed the title ember-cli: remove mkYarnDeps usage ember-cli: remove mkYarnPackage usage Sep 15, 2024
@ofborg ofborg bot requested a review from jfvillablanca September 16, 2024 00:09
@TomaSajt TomaSajt marked this pull request as ready for review September 19, 2024 21:01
@jfvillablanca
Copy link
Member

Result of nixpkgs-review pr 342153 run on x86_64-linux 1

1 package built:
  • ember-cli

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 22, 2024
@r-vdp r-vdp merged commit 9c3d3e0 into NixOS:master Nov 3, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfvillablanca jfvillablanca jfvillablanca approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomaSajt @dotlambda @jfvillablanca @r-vdp @wegank