Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gancio: remove mkYarnPackage usage #341917

Merged
merged 2 commits into from
Nov 28, 2024
Merged

gancio: remove mkYarnPackage usage #341917

merged 2 commits into from
Nov 28, 2024

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Sep 14, 2024 •
edited
Loading

Description of changes

Tracking issue: #324246

  • swapped over to using yarn*Hook instead of using mkYarnPackage
  • enabled using the system sqlite package

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@TomaSajt TomaSajt marked this pull request as draft September 14, 2024 22:00
@TomaSajt TomaSajt marked this pull request as ready for review September 14, 2024 22:23
@ofborg ofborg bot requested a review from jbgi September 14, 2024 23:03
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 14, 2024
jbgi
jbgi approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@jbgi jbgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 19, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2024
@erictapen erictapen self-requested a review October 23, 2024 09:08
@TomaSajt TomaSajt force-pushed the gancio branch 2 times, most recently from 4b9c251 to ebeea8d Compare October 29, 2024 11:28
@TomaSajt TomaSajt removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 29, 2024
@wegank wegank removed 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Oct 29, 2024
@ofborg ofborg bot requested a review from jbgi October 29, 2024 15:48
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 31, 2024
@jbgi
Copy link
Contributor

jbgi commented Nov 2, 2024 •
edited
Loading

should pkgs/by-name/ga/gancio/plugin-telegram-bridge be migrated too as part of this PR or separately?

@TomaSajt
Copy link
Contributor Author

TomaSajt commented Nov 5, 2024

should pkgs/by-name/ga/gancio/plugin-telegram-bridge be migrated too as part of this PR or separately?

Oh, I somehow didn't notice that...
I'll try to migrate that too in this PR

@TomaSajt TomaSajt marked this pull request as draft November 5, 2024 21:36
@TomaSajt TomaSajt marked this pull request as ready for review November 5, 2024 21:53
@wegank wegank removed 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 5, 2024
@ofborg ofborg bot requested a review from jbgi November 6, 2024 06:01
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 6, 2024
@jbgi
Copy link
Contributor

jbgi commented Nov 27, 2024

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@jbgi merge not permitted (#305350):
pr author is not in restricted authors list, in the list are: r-ryantm

@jbgi jbgi mentioned this pull request Nov 27, 2024
Closed
@TomaSajt
Copy link
Contributor Author

@NixOS/nixpkgs-merge-bot merge

Should I merge it?

@jbgi
Copy link
Contributor

jbgi commented Nov 28, 2024

Should I merge it?

yes please, thanks!

@TomaSajt TomaSajt merged commit 583cf87 into NixOS:master Nov 28, 2024
32 checks passed
@jbgi jbgi added the backport release-24.11 Backport PR automatically label Nov 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 28, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@jbgi jbgi jbgi approved these changes

@erictapen erictapen Awaiting requested review from erictapen

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomaSajt @jbgi @Aleksanaa @wegank