Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zitadel.console: remove mkYarnPackage usage #341784

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

TomaSajt
Copy link
Contributor

Description of changes

Tracking issue: #324246

Most of the patches could be removed, because they were only required for the weird directory layout provided by mkYarnPackage.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2024
@TomaSajt TomaSajt changed the title zitadel: rework console drv to use yarn hooks zitadel.console: remove mkYarnPackage usage Oct 29, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 29, 2024
@FliegendeWurst FliegendeWurst added needs_merger 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 12, 2024
@kirillrdy
Copy link
Member

--------- Report for 'x86_64-linux' ---------
1 package built:
zitadel

@kirillrdy kirillrdy merged commit 6da9bf9 into NixOS:master Nov 13, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants