Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

burpsuite: 2024.6.6 -> 2024.7.6, add missing dependency for built-in browser #340953

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

cryptoluks
Copy link
Contributor

@cryptoluks cryptoluks commented Sep 10, 2024

Description of changes

Note: The Burp menu's browser health check successfully identified the missing dependency.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 10, 2024
@cryptoluks cryptoluks changed the title Fix Burp Suite Browser Startup Issue, Disable Auto-Update, and Bump Version to 2024.7.5 Update BurpSuite to 2024.7.6 and add missing dependency for built-in browser Sep 18, 2024
@cryptoluks cryptoluks requested a review from bennofs September 18, 2024 08:05
Copy link
Member

@surfaceflinger surfaceflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me

@surfaceflinger
Copy link
Member

@cryptoluks could you amend the commit message to eg.
burpsuite: 2024.6.6 -> 2024.7.6, add missing dependency for built-in browser?

@cryptoluks cryptoluks changed the title Update BurpSuite to 2024.7.6 and add missing dependency for built-in browser burpsuite: 2024.6.6 -> 2024.7.6, add missing dependency for built-in browser Sep 20, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 22, 2024
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit 8401ab0 into NixOS:master Oct 7, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants