-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildRustPackage: allow passing in cargoDeps #340798
base: master
Are you sure you want to change the base?
buildRustPackage: allow passing in cargoDeps #340798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overlay you show has never worked; we've never exposed cargoLock
in passthru, only cargoDeps
. Are you sure you don't mean to use wezterm.cargoDeps
(or wezterm.passthru.cargoDeps
) in it?
Derp 🤦🏼 I found the commit which I dropped by accident while rebasing 4f4c193
In essence I want this but it fails on https://github.com/nixos/nixpkgs/blob/bcbfad30628c60e310e5f7c95436de2f0c05921e/pkgs/build-support/rust/build-rust-package/default.nix#L62-L64 Maybe that should be extended instead? |
This is useful when constructing overlays and trying to copy a buildRustPackage from a different package
bcbfad3
to
7243e1b
Compare
@winterqt ping |
Probably superseded by #354999 |
Description of changes
Since roughly a week or so the following overlay fails and I couldn't so far figure out why because the changes done in the last ~3 months or so look rather innocent.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.