papers: Make thumbnailer file point to absolute path #340625
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
tomodachi94
requested changes
Sep 9, 2024
anewdi
changed the title
Allows use with nautilus(bubblewrap) even if installed in home.packages
tomodachi94
approved these changes
Sep 11, 2024
|
Yeah, that would be great! |
wegank
added
the
12.approvals: 1
|
Is there anything missing here or does it usually take some time for it to get merged? |
|
Sorry, was waiting for CI and then forgotten about it. |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-340625-to-release-24.05 origin/release-24.05
cd .worktree/backport-340625-to-release-24.05
git switch --create backport-340625-to-release-24.05
git cherry-pick -x 8ce371c4840c624f49796e32913287ae94092038 |
|
I tried to follow the steps from the bot, but what do i do now? Where do i push? |
|
Manual pull request? |
|
Yes, manual pull request will be needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Allows use with nautilus(bubblewrap) even if installed in home.packages
Things done
Built on platform(s)
Tested basic functionality of all binary files (usually in
./result/bin/)Fits CONTRIBUTING.md.