Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

so: fix build #340345

Merged
merged 1 commit into from
Sep 8, 2024
Merged

so: fix build #340345

merged 1 commit into from
Sep 8, 2024

Conversation

UnsolvedCypher
Copy link
Contributor

Description of changes

Building on Darwin aarch-64 fails with:

   Compiling so v0.4.10 (/private/tmp/nix-build-so-0.4.10.drv-0/so-source-0.4.10)
error: linking with `/nix/store/2hi8rl1w19i0v57jdcplyfnag9hyk9y3-clang-wrapper-16.0.6/bin/cc` failed: exit status: 1
  |
  = note: env -u IPHONEOS_DEPLOYMENT_TARGET -u TVOS_DEPLOYMENT_TARGET -u XROS_DEPLOYMENT_TARGET LC_ALL="C" PATH="/nix/store/xw16bz6bpzyrrwcwqz32i>
  = note: ld: framework not found CoreServices
          clang-16: error: linker command failed with exit code 1 (use -v to see invocation)


error: could not compile `so` (bin "so") due to 1 previous error

Failure seems similar to #340323 .

I added the missing build inputs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • Not a significant change for release notes
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 7, 2024
@Artturin Artturin merged commit add0443 into NixOS:master Sep 8, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants