Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oscavmgr: init at 0.4.1 #339627

Merged
merged 1 commit into from
Sep 9, 2024
Merged

oscavmgr: init at 0.4.1 #339627

merged 1 commit into from
Sep 9, 2024

Conversation

Scrumplex
Copy link
Member

Description of changes

Utility for face tracking for VRChat and Resonite. Not very useful for VRChat unless VrcAdvert is also packaged.

https://github.com/galister/oscavmgr

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Scrumplex Scrumplex mentioned this pull request Sep 4, 2024
13 tasks
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 4, 2024
pkgs/by-name/os/oscavmgr/package.nix Show resolved Hide resolved
pkgs/by-name/os/oscavmgr/package.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

meta = {
description = "Face tracking & utilities for Resonite and VRChat";
homepage = "https://github.com/galister/oscavmgr";
changelog = "https://github.com/galister/oscavmgr/releases/tag/v${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
changelog = "https://github.com/galister/oscavmgr/releases/tag/v${version}";
changelog = "https://github.com/galister/oscavmgr/releases";

I strongly prefer this, but I won't block on it as there is a lack of consensus

pkgs/by-name/os/oscavmgr/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/os/oscavmgr/package.nix Outdated Show resolved Hide resolved
@Pandapip1 Pandapip1 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 7, 2024
Signed-off-by: Sefa Eyeoglu <[email protected]>
@ofborg ofborg bot requested a review from Pandapip1 September 7, 2024 07:31
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Sep 7, 2024
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Sep 7, 2024
Copy link
Contributor

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ofborg re-requested my review

@wegank wegank merged commit 6c38abd into NixOS:master Sep 9, 2024
29 of 30 checks passed
@Pandapip1
Copy link
Contributor

FYI - VRCAdvert is also packaged.

@Scrumplex Scrumplex deleted the pkgs/oscavmgr/init branch September 9, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants