-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oscavmgr: init at 0.4.1 #339627
oscavmgr: init at 0.4.1 #339627
Conversation
732b111
to
c5fd843
Compare
1ae72a3
to
2693d8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM.
meta = { | ||
description = "Face tracking & utilities for Resonite and VRChat"; | ||
homepage = "https://github.com/galister/oscavmgr"; | ||
changelog = "https://github.com/galister/oscavmgr/releases/tag/v${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog = "https://github.com/galister/oscavmgr/releases/tag/v${version}"; | |
changelog = "https://github.com/galister/oscavmgr/releases"; |
I strongly prefer this, but I won't block on it as there is a lack of consensus
2693d8a
to
28058c6
Compare
Signed-off-by: Sefa Eyeoglu <[email protected]>
28058c6
to
15b6601
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ofborg re-requested my review
FYI - VRCAdvert is also packaged. |
Description of changes
Utility for face tracking for VRChat and Resonite. Not very useful for VRChat unless VrcAdvert is also packaged.
https://github.com/galister/oscavmgr
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.