-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rstudio: 1.1.383 -> 1.1.414 #33901
rstudio: 1.1.383 -> 1.1.414 #33901
Conversation
Thanks! |
@sifmelcara it doesn't look like rstudio uses the updated rsconnect that you've updated I'm using the master branch of nixpkgs & installed rstudio via: In the ide I see:
thoughts? |
Hmm... It even failed to show the gui on current master.
After bisecting, I found it was broken by #33297 being merged into master. @joncfoo Although I'm not a expert about R and rstudio, I think you may got that |
@joncfoo What I tried to say is that rstudio seems not to come with |
@sifmelcara did you install Rstudio in your profile or started it via nix-shell? It could also be, that you have the wrong qt version installed in your profile. Some explanation from @ttuegel #30551 (comment) |
@Mic92 I started it by executing |
So I found setting postInstall = ''
- wrapProgram $out/bin/rstudio --suffix PATH : ${gnumake}/bin
+ wrapProgram $out/bin/rstudio --suffix PATH : ${gnumake}/bin \
+ --set QT_QPA_PLATFORM_PLUGIN_PATH ${qtbase.bin}/lib/qt-*/plugins/platforms
mkdir $out/share
cp -r ${desktopItem}/share/applications $out/share
mkdir $out/share/icons |
@sifmelcara yes, you need to use |
Ok, thank you for the clarification! |
@sifmelcara thanks for looking into this - I did have rsconnect installed locally as you mentioned. btw I used |
Motivation for this change
Fix build by updating rstudio version.
Old version of rstudio fails to build on current nixpkgs master because it do not support new version of boost. (rstudio/rstudio#1897)
Things done
fetchurl
tofetchFromGitHub
(GitHub unstable archive tracking issue #32997)rstudio
,rmarkdown
andrsconnect
.cc maintainers @ehmry @changlinli @ciil
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)