Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proton-pass: 1.22.0 -> 1.22.1 #337323

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

MrSom3body
Copy link
Contributor

@MrSom3body MrSom3body commented Aug 25, 2024

Description of changes

https://github.com/ProtonMail/WebClients/blob/main/applications/pass-desktop/CHANGELOG.md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Aug 25, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 25, 2024
@SebTM
Copy link
Contributor

SebTM commented Aug 26, 2024

Result of nixpkgs-review pr 337323 run on x86_64-linux 1

1 package built:
  • proton-pass

@SebTM SebTM added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Aug 26, 2024
@SebTM SebTM merged commit 3d81b7c into NixOS:master Aug 26, 2024
29 of 31 checks passed
@SebTM
Copy link
Contributor

SebTM commented Aug 26, 2024

@MrSom3body Thanks for the contribution :)

@MrSom3body MrSom3body deleted the proton-pass_1.22.1 branch August 26, 2024 11:49
@DrPacar
Copy link

DrPacar commented Oct 6, 2024

thanks :) You helped me get through this error and problem. My version was so bugged, i did a backflip while it did not work. When i saw this fix, I realisied how much of a god you really are. I love you. If you want to stay in contact please dm me. <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants