Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs_22: 22.6.0 -> 22.7.0 #336556

Merged
merged 1 commit into from
Aug 23, 2024
Merged

nodejs_22: 22.6.0 -> 22.7.0 #336556

merged 1 commit into from
Aug 23, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Aug 22, 2024

Description of changes

https://github.com/nodejs/node/releases/tag/v22.7.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 22, 2024
@dasJ dasJ merged commit c455cc3 into NixOS:staging Aug 23, 2024
27 of 29 checks passed
@aduh95 aduh95 deleted the upgrade-node-22 branch August 23, 2024 09:49
@emilazy
Copy link
Member

emilazy commented Sep 3, 2024

This version suffers from nodejs/node#54543. There is a merged PR (nodejs/node#54565) waiting for a v22.8.0 release. We may want to roll back here, vendor the PR, or just let it be broken until the next release since this isn’t the default version anyway.

@emilazy
Copy link
Member

emilazy commented Sep 3, 2024

v22.8.0 is expected within, like, a day, so we can just bump to that.

@aduh95 aduh95 mentioned this pull request Sep 3, 2024
13 tasks
@aduh95
Copy link
Contributor Author

aduh95 commented Sep 3, 2024

I've opened #339252 to bump it.

@emilazy
Copy link
Member

emilazy commented Sep 3, 2024

You beat me to it :)

aduh95 added a commit to aduh95/nixpkgs that referenced this pull request Sep 6, 2024
dasJ pushed a commit that referenced this pull request Sep 13, 2024
* nodejs_18: pin to Python 3.11, fix tests with OpenSSL 3.0.14

(cherry picked from commit 7c1177c)

* nodejs: use upstream patch instead of custom one

(cherry picked from commit f75d503)

* nodejs_22: 22.4.1 -> 22.5.1

(cherry picked from commit 070791f)

* nodejs: use .finalPackage for ease of overriding

Previously, the nodejs `passthru.pkgs` attribute refers to the package
fixed point derived in the current context, without considering
potential overrides to the main nodejs package.

This is fixed here with the `.finalPackage` attribute, which refers to
the final package fixed point, after potential overrides.

For example, previously, after overriding nodejs with `nodejs.override`,
`nodejs.pkgs` would still refer to the original package, instead of the
overridden one. After this fix, `nodejs.pkgs` would be correctly based
on the overridden `nodejs` package.

(cherry picked from commit ee9a623)

* nodejs: fix tests and disable parallel checking

(cherry picked from commit d7f46fb)

* nodejs: disable failing tests on x86_64-darwin

(cherry picked from commit 31d2381)

* nodejs: skip tests failing in sandbox in all platforms

ce685a8 added list of tests failing on sandbox, but for some reason
only for Darwin. We should skip those tests on all platforms otherwise
OfBorg builds are failing.

(cherry picked from commit f5846d2)

* nodejs_20: 20.15.1 -> 20.16.0

(cherry picked from commit 35b556d)

* nodejs: 22.5.1 -> 22.6.0 (#333210)

(cherry picked from commit 4c38d8a)

* nodejs_22: 22.6.0 -> 22.7.0 (#336556)

(cherry picked from commit c455cc3)

* nodejs_20: 20.16.0 -> 20.17.0 (#336388)

(cherry picked from commit 45db1ff)

* nodejs_22: 22.7.0 -> 22.8.0

(cherry picked from commit 235ae9c)

---------

Co-authored-by: K900 <[email protected]>
Co-authored-by: Bryan Lai <[email protected]>
Co-authored-by: Ivan Trubach <[email protected]>
lblasc pushed a commit to tvbeat/nixpkgs that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants