python3Packages.array-api-strict: remove with lib for meta #335446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
SigmaSquadron
approved these changes
Aug 17, 2024
| license = licenses.bsd3; | ||
| maintainers = [ maintainers.berquist ]; | ||
| license = lib.licenses.bsd3; | ||
| maintainers = [ lib.maintainers.berquist ]; |
There was a problem hiding this comment.
Suggested change
| maintainers = [ lib.maintainers.berquist ]; | |
| maintainers = with lib.maintainers; [ berquist ]; |
Optional style change, not a blocker. See the discussion in #331085 and choose whether you want to keep this as-is, or use with.
SigmaSquadron
added
the
12.approvals: 1
berquist
force-pushed
the
remove-with-lib-for-meta
branch
5 times, most recently
from
320f912 to
d602467
Compare
wegank
removed
the
12.approvals: 1
berquist
force-pushed
the
remove-with-lib-for-meta
branch
from
d602467 to
0aba3e3
Compare
- remove meta with lib (NixOS#208242) - use with lib.maintainers (NixOS#331085) - remove unnecessary trivial nix-update-script for Python packages
berquist
force-pushed
the
remove-with-lib-for-meta
branch
from
0aba3e3 to
8525a69
Compare
SigmaSquadron
suggested changes
Aug 22, 2024
SigmaSquadron
approved these changes
Aug 23, 2024
SigmaSquadron
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.