rerun: 0.13.0 -> 0.18.2

[RobWalt]

Description of changes

• the patches are not necessary anymore
• the repository now exposes other build targets, so we need to specifically build the rerun-cli package with native_viewer feature
• this crate was also hit by this issue with rust 1.80, the crate itself ships with a rust-toolchain file which states which rust version they use upstream, so I went ahead and build the crate with a non standard rustPlatform (1.76 instead of 1.80 currently, but the toolchain now updates with the src)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[alyssais]

Upstream provides a Cargo.lock, so we don't need to put it in Nixpkgs — we can use cargoHash and just put a small patch updating time in cargoPatches.

[RobWalt]

Thanks, TIL cargoPatches exist! I didn't know about that yet. Are there any better docs on the the rust utilities other than this or grepping through nixpkgs?

[alyssais]

I don't think so. The documentation you linked does mention cargoPatches, but not in a reference list of attributes, so I can see how you missed it. I've found that using grep to try to find how the same problem is solved in other packages to be the best way.

[SomeoneSerge]

@RobWalt you beat me to it! Thanks!

I noticed the patch generated from the master branch isn't applicable to the release commit, so I wanted to look into whether it's possible to pass a postPatch to the FOD and use some kind of a TOML editor to reset the versions unconditionally so that the "patch" would be more generally applicable. I'm unhappy about override-ability of this kind of packages...

[alyssais]

   error: undefined variable 'RobWalt'

Do you need to add yourself to maintainers.nix? (If so, please do so in a separate commit, before the current one.)

[RobWalt]

   error: undefined variable 'RobWalt'

Do you need to add yourself to maintainers.nix? (If so, please do so in a separate commit, before the current one.)

I'm sorry for all the little nits you needed to comment on. It was just robwalt instead of RobWalt 🤦🏼

[SomeoneSerge]

@ofborg build python312Packages.rerun-sdk

Did I forget to add that to passthru tests?

[SomeoneSerge]

rerun-cli: 0.13.0 -> 0.17.0

The name of the package in nixpkgs is rerun, that should reflect in the commit message in order to trigger Ofborg. It seems like upstream has changed the target name in their cargo file? I'm not opposed to renaming the attribute to rerun-cli instead of rerun (with an alias), although I feel like that'd be unnecessary friction

[SomeoneSerge]

Don't you also need to patch Cargo.toml and its rust-version?

[RobWalt]

I think this is mostly cosmetric and not picked up by cargo commands

[SomeoneSerge]

Apparently not? Ofborg says:

       >
       > Cargo.lock is not the same in /build/rerun-0.17.0-vendor.tar.gz
       >
       > To fix the issue:
       > 1. Set cargoHash/cargoSha256 to an empty string: `cargoHash = "";`
       > 2. Build the derivation and wait for it to fail with a hash mismatch
       > 3. Copy the "got: sha256-..." value back into the cargoHash field
       >    You should have: cargoHash = "sha256-XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

https://github.com/NixOS/nixpkgs/pull/334854/checks?check_run_id=28868560235

[RobWalt]

rerun-cli: 0.13.0 -> 0.17.0

The name of the package in nixpkgs is rerun, that should reflect in the commit message in order to trigger Ofborg. It seems like upstream has changed the target name in their cargo file? I'm not opposed to renaming the attribute to rerun-cli instead of rerun (with an alias), although I feel like that'd be unnecessary friction

I think in the end it's just the package name that changed and is now called rerun-cli. The binary is still named rerun. I'll change the title of the PR

[SomeoneSerge]

I'll change the title of the PR

ok by me but Ofborg looks at the commit message not at the PR title

[RobWalt]

@SomeoneSerge I think it ran through now successfully 🤠

[SomeoneSerge]

H'm, I'm still seeing this:

[RobWalt]

Sorry, you're right 😬

[alyssais]

Hash mismatch on OfBorg.

[SomeoneSerge]

Yes, my presumption still is that it's #334854 (comment)

[RobWalt]

Took me a while but the passthru tests now build locally and are all green. Thanks to you two I learned a lot!

@SomeoneSerge FYI

[alyssais]

I'll leave the final check to @SomeoneSerge.

[SomeoneSerge]

I didn't do much thorough testing but nix run github:RobWalt/nixpkgs/rerun-0.17#rerun works as expected. Thank you @RobWalt!