Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vaultwarden: 1.31.0 -> 1.32.0 #334048

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Aug 12, 2024

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for vaultwarden is: Unofficial Bitwarden compatible server written in Rust

meta.homepage for vaultwarden is: https://github.com/dani-garcia/vaultwarden

meta.changelog for vaultwarden is: https://github.com/dani-garcia/vaultwarden/releases/tag/1.32.0

closes #334047
closes #334046

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.32.0 with grep in /nix/store/49k23hmnvgqjghwsw315dl7rgcmh8zib-vaultwarden-1.32.0
  • found 1.32.0 in filename of file in /nix/store/49k23hmnvgqjghwsw315dl7rgcmh8zib-vaultwarden-1.32.0

Rebuild report (if merged into master) (click to expand)
7 total rebuild path(s)

7 package rebuild(s)

First fifty rebuilds by attrpath

nixos-install-tools
tests.nixos-functions.nixos-test
vaultwarden
vaultwarden-mysql
vaultwarden-postgresql
vaultwarden-sqlite
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/49k23hmnvgqjghwsw315dl7rgcmh8zib-vaultwarden-1.32.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A vaultwarden https://github.com/r-ryantm/nixpkgs/archive/ae16dda224edbf624f0016b6489933d45ab55a08.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/ae16dda224edbf624f0016b6489933d45ab55a08#vaultwarden

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/49k23hmnvgqjghwsw315dl7rgcmh8zib-vaultwarden-1.32.0
ls -la /nix/store/49k23hmnvgqjghwsw315dl7rgcmh8zib-vaultwarden-1.32.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package blacklisted:
  • nixos-install-tools
3 packages built:
  • vaultwarden
  • vaultwarden-mysql
  • vaultwarden-postgresql

Maintainer pings

cc @dotlambda @SuperSandro2000 for testing.


Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from SuperSandro2000 and dotlambda August 12, 2024 03:56
@dotlambda dotlambda added 1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 12, 2024
@tanneberger
Copy link
Contributor

tanneberger commented Aug 12, 2024

https://github.com/dani-garcia/vaultwarden/releases/tag/1.32.0

"This release has several CVE Reports fixed and we recommend everybody to update to the latest version as soon as possible."

So a backport to 24.05 is in order.

@SuperSandro2000
Copy link
Member

We need to create the backports PR manually. Will do that soon ™️

@SuperSandro2000
Copy link
Member

#334099

@SuperSandro2000 SuperSandro2000 removed the 9.needs: port to stable A PR needs a backport to the stable release. label Aug 12, 2024
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a quick smoke test and nothing immediately exploded

@SuperSandro2000 SuperSandro2000 merged commit 2e11a22 into NixOS:master Aug 12, 2024
34 of 36 checks passed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/several-information-leaks-in-vaultwarden-1-32-0/50500/1

@r-ryantm r-ryantm deleted the auto-update/vaultwarden branch August 12, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants