Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-lc: init at 1.37.0 #333578

Closed
wants to merge 2 commits into from
Closed

Conversation

theoparis
Copy link
Contributor

@theoparis theoparis commented Aug 10, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

I have marked this as a draft because pkgsStatic.aws-lc fails to build and I'm yet to figure out the "no such file or directory" errors.

Add a 👍 reaction to pull requests you find important.

Sorry, something went wrong.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Aug 10, 2024
@theoparis theoparis marked this pull request as ready for review August 10, 2024 02:24
@RossComputerGuy RossComputerGuy self-assigned this Aug 10, 2024
@RossComputerGuy RossComputerGuy self-requested a review August 10, 2024 02:38
pkgs/by-name/aw/aws-lc/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/aw/aws-lc/package.nix Outdated Show resolved Hide resolved
@RossComputerGuy
Copy link
Member

Result of nixpkgs-review pr 333578 run on aarch64-linux 1

3 packages built:
  • aws-lc
  • aws-lc.bin
  • aws-lc.dev

@theoparis
Copy link
Contributor Author

theoparis commented Aug 13, 2024

Hmm, there seems to be failing builds on darwin platforms. and I'm not sure what's going on.
Related: openssl/openssl#16409

/nix/store/hmchx96ysd0h19p7kx0w12pljkbp30j3-Libsystem-1238.60.2/include/CommonCrypto/CommonRandom.h:35:9: error: unknown type name 'CCCryptorStatus'

Edit: I've attempted to fix this by overriding the SDK to 11.0 on darwin... I also applied a patch that fixes pkg-config files - I should probably PR this to aws-lc if this is correct.
Edit 2: The patch has been upstreamed, waiting for a release

@theoparis theoparis changed the title aws-lc: init at 1.33.0 aws-lc: init at 1.36.1 Oct 9, 2024
@theoparis theoparis changed the title aws-lc: init at 1.36.1 aws-lc: init at 1.37.0 Oct 20, 2024

Verified

This commit was signed with the committer’s verified signature.
theoparis Theo Paris

Verified

This commit was signed with the committer’s verified signature.
theoparis Theo Paris
@theoparis

This comment was marked as resolved.

@tinted-software tinted-software closed this by deleting the head repository Nov 8, 2024
@theoparis
Copy link
Contributor Author

Sorry I messed up, new PR is here #356628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants