Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.05] teleport_15: 15.3.7 -> 15.4.11 #333434

Closed

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 9, 2024

Bot-based backport to release-24.05, triggered by a label in #333048.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

(cherry picked from commit 214aaa5)
@pbsbot
Copy link

pbsbot commented Sep 8, 2024

Result of nixpkgs-review pr 333434 run on x86_64-linux 1

2 packages built:
  • teleport (teleport_15)
  • teleport.client (teleport_15.client)

@pbsds
Copy link
Member

pbsds commented Sep 8, 2024

skimming the release notes it strikes me as a minorly breaking change, why should this be backported @justinas?

@justinas
Copy link
Contributor

justinas commented Sep 8, 2024

skimming the release notes it strikes me as a minorly breaking change, why should this be backported @justinas?

What in the release notes stands out as breaking? Generally Teleport follows semver and should not break anything in a minor release.

I'm backporting per:

Minor versions with new functionality, but no breaking changes

In the backporting criteria.

@pbsds
Copy link
Member

pbsds commented Sep 8, 2024

@justinas
Copy link
Contributor

justinas commented Sep 8, 2024

https://github.com/gravitational/teleport/releases/tag/v15.4.10 removes functionality

Good catch, thanks. That is somewhat unusual. I'm fine with not backporting this.

@justinas justinas closed this Sep 8, 2024
@pbsds pbsds deleted the backport-333048-to-release-24.05 branch September 24, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants