Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.mkdocs-drawio-exporter: fix after migration to poetry #333395

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

0xf09f95b4
Copy link
Contributor

@0xf09f95b4 0xf09f95b4 commented Aug 9, 2024

Description of changes

mkdocs-drawio-exporter moved its dependency management to poetry in 0.9.0. This was not caught in the last package update in unstable, leading to build failures.

Due to this change, the mirror URL as well as the module name for imports changed.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@mweinelt: FYI, the last major update broke this package in unstable.


Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Aug 9, 2024
@ofborg ofborg bot requested a review from snpschaaf August 9, 2024 09:06
@0xf09f95b4 0xf09f95b4 force-pushed the fix-mkdocs-drawio-exporter branch 2 times, most recently from 786998b to 1b222dd Compare August 9, 2024 12:52
The upstream repository of mkdocs-drawio-exporter was migrated to poetry.

The last package update did not address this issue, causing build failures.
@0xf09f95b4 0xf09f95b4 force-pushed the fix-mkdocs-drawio-exporter branch from 1b222dd to 0b62c5c Compare August 9, 2024 13:23
@mweinelt mweinelt changed the title mkdocs-drawio-exporter: fix after migration to poetry python312Packages.mkdocs-drawio-exporter: fix after migration to poetry Aug 9, 2024
@mweinelt mweinelt merged commit 8e0e9b1 into NixOS:master Aug 9, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants