-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tree-sitter-sql: fix source hash #332824
base: master
Are you sure you want to change the base?
tree-sitter-sql: fix source hash #332824
Conversation
@ofborg build tree-sitter-grammars.tree-sitter-sql |
Well that's fun, there must be some casing differences in some filenames so the hash ends up different on mac and linux :( NixOS:
macOS:
Edit: Oh treesitter grammars are all redefined inside nvim-treesitter and don't use the same derivations as tree-sitter-grammars. |
@ofborg build vimPlugins.nvim-treesitter.grammarPlugins.sql |
Result of 1 package failed to build:
1 package built:
|
Here is the current error I'm getting on mac, it looks to me as if this hash is indeed different on macOS:
|
How is the hash obtained? Is there a wrapper script that could have a platform-specific bug? I assume the archive itself is identical on both platforms, since it is fetched from github using the same repo & revision. If so, either the hashing process or the download/copying process must have a platform-specific bug 🤔 I guess any bug here would likely be in the nix binary itself though, so I'd expect it to affect more packages. Maybe I'm barking up the wrong tree... |
Converting this to a draft as from the discussion it seems this wouldn't work if merged. |
perhaps something upstream got fixed as I just update my flake this morning and now I am not having this issue on macos anymore. |
Can confirm, it builds fine on macOS now! |
Description of changes
Patched tree-sitter-sql hash, which is incorrect as it stands.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.