pkgs/development: remove unused arguments #331886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
6.topic: haskell
6.topic: qt/kde
6.topic: rust
6.topic: golang
6.topic: ruby
6.topic: erlang
6.topic: ocaml
6.topic: nodejs
6.topic: lua
6.topic: php
6.topic: llvm/clang
Sigmanificient
force-pushed
the
remove-unused-arguments-pkgs-dev
branch
8 times, most recently
from
3bfa54b to
ea57762
Compare
Sigmanificient
force-pushed
the
remove-unused-arguments-pkgs-dev
branch
4 times, most recently
from
bc47f74 to
acbf14a
Compare
Sigmanificient
force-pushed
the
remove-unused-arguments-pkgs-dev
branch
from
acbf14a to
63d05d9
Compare
ofborg
bot
added
the
10.rebuild-darwin: 0
Sigmanificient
requested review from
katexochen,
Mic92,
zowoq,
aanderse,
drupol,
globin,
Ma27,
talyz,
Profpatsch,
K900,
NickCao,
SuperSandro2000,
ttuegel,
RossComputerGuy,
winterqt,
figsoda,
sternenseemann,
maralorn and
ncfavier
as code owners
|
Result of |
corngood
approved these changes
Aug 3, 2024
wegank
added
the
12.approvals: 3+
|
63d05d9 |
|
Oh no! I'm sorry for this, I hope this gets merge rapidly |
|
Done ;) |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
A lot of progress has been made and over 2000 unused args of them were removed!
With previous bits, ocaml & python packages cleaned-up, there is few enough to to a whole pass on
pkgs/development.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.