postgresqlPackages.postgis: enable tests #331876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
requested review from
MarcWeber,
nh2,
wolfgangwalther,
willcohen,
l0b0,
sikmir,
nialov and
autra
|
Result of 20 packages built:
|
|
Looks good to me and I very much support adding the tests. Good job.
Ping me once you have PR in final state. |
+1 from me. |
wolfgangwalther
requested changes
Aug 3, 2024
kirillrdy
changed the title
l0b0
approved these changes
Aug 4, 2024
wegank
added
12.approvals: 1
|
#332764 has landed in master |
wegank
removed
the
12.approvals: 1
|
Result of 20 packages built:
|
imincik
approved these changes
Aug 15, 2024
|
@imincik ah sorry, i force pushed the old version :-( |
imincik
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
until #331166 reaches master postgis is broken
running postgis tests does catch that regression
I am going to remove all postgresql overrides before merging, it's there for review+testing
how do people feel about nixfmt-rfc-style ?
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.