-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nc4nix: 0-unstable-2024-03-01 -> 0-unstable-2024-08-01 #331507
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1ad15c9
Revert "nextcloud{28,29}Packages: improve generation script"
dotlambda b8a80e1
Revert "nextcloudPackages: Revamp package generation script"
dotlambda 73eb537
nc4nix: 0-unstable-2024-03-01 -> 0-unstable-2024-08-01
dotlambda 2c1d58e
nextcloudPackages: update
dotlambda 5c81204
nextcloud-notify_push: 0.6.12 -> 0.7.0
dotlambda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,31 @@ | ||
{ lib | ||
, buildGoModule | ||
, fetchFromGitHub | ||
{ | ||
lib, | ||
buildGoModule, | ||
fetchFromGitHub, | ||
unstableGitUpdater, | ||
}: | ||
|
||
buildGoModule { | ||
pname = "nc4nix"; | ||
version = "0-unstable-2024-03-01"; | ||
version = "0-unstable-2024-08-01"; | ||
|
||
src = fetchFromGitHub { | ||
owner = "helsinki-systems"; | ||
repo = "nc4nix"; | ||
rev = "ba37674c0dddf93e0a011dace92ec7f0ec834765"; | ||
hash = "sha256-k12eeP2gojLCsJH1GGuiTmxz3ViPc0+oFBuptyh42Bw="; | ||
rev = "827bb7244a3529e71c9474fe1f74aed51a4b08d5"; | ||
hash = "sha256-ToT+VvdXiUMmy0dNJAeyMlzMx87QhZPIwzxPXm2fR7s="; | ||
}; | ||
|
||
vendorHash = "sha256-ZXl4kMDY9ADkHUcLsl3uNpyErMzbgS+J65+uUeIXpSE="; | ||
vendorHash = "sha256-qntRsv3KvAbV3lENjAHKkQOqh3uTo3gacfwase489tQ="; | ||
|
||
meta = with lib; { | ||
passthru.updateScript = unstableGitUpdater { }; | ||
|
||
meta = { | ||
description = "Packaging helper for Nextcloud apps"; | ||
mainProgram = "nc4nix"; | ||
homepage = "https://github.com/helsinki-systems/nc4nix"; | ||
license = licenses.mit; | ||
maintainers = with maintainers; [ onny ]; | ||
platforms = platforms.linux; | ||
license = lib.licenses.mit; | ||
maintainers = with lib.maintainers; [ onny ]; | ||
platforms = lib.platforms.linux; | ||
}; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,64 +1,14 @@ | ||
#!/usr/bin/env nix-shell | ||
#! nix-shell -i bash -p jq gnused curl | ||
#! nix-shell -I nixpkgs=../../../.. -i bash -p nc4nix jq | ||
|
||
set -e | ||
set -u | ||
set -o pipefail | ||
set -x | ||
|
||
cd $(dirname -- "${BASH_SOURCE[0]}") | ||
|
||
export NEXTCLOUD_VERSIONS=$(nix-instantiate --eval -E 'import ./nc-versions.nix {}' -A e) | ||
|
||
APPS=$(jq -r 'keys|.[]' nextcloud-apps.json | sed -z 's/\n/,/g;s/,$/\n/') | ||
|
||
for v in ${NEXTCLOUD_VERSIONS//,/ }; do | ||
# Get major version and back up previous major version apps file | ||
v=$(sed -e 's/^"//' -e 's/"$//' <<<"$v") | ||
MAJOR=${v%.*.*} | ||
MAJOR_FILE="$MAJOR".json | ||
mv "$MAJOR_FILE" "$MAJOR_FILE".bak | ||
|
||
# Download current apps file from Nextcloud's official servers | ||
APPS_PER_VERSION=${v}.json | ||
curl "https://apps.nextcloud.com/api/v1/platform/${v}/apps.json" -o "$APPS_PER_VERSION" | ||
|
||
# Add a starting bracket to the apps file for this version | ||
echo '{' >"$MAJOR_FILE".tmp | ||
for a in ${APPS//,/ }; do | ||
echo "Fetching $a" | ||
# Ensure the app exists in the file | ||
if [ "$(jq -r ".[] | select(.id == \"${a}\")" "$APPS_PER_VERSION")" != "" ]; then | ||
# Get all of our variables | ||
VERSION=$(jq -r ".[] | select(.id == \"${a}\") | .releases[0].version" "$APPS_PER_VERSION") | ||
URL=$(jq -r ".[] | select(.id == \"${a}\") | .releases[0].download" "$APPS_PER_VERSION") | ||
HASH=$(nix --extra-experimental-features nix-command store prefetch-file --json --hash-type sha256 --unpack "$URL" | jq -r .hash) | ||
HOMEPAGE=$(jq -r ".[] | select(.id == \"${a}\") | .website" "$APPS_PER_VERSION") | ||
DESCRIPTION=$(jq ".[] | select(.id == \"${a}\") | .translations.en.description" "$APPS_PER_VERSION") | ||
# Add all variables to the file | ||
cat >>"$MAJOR_FILE".tmp <<EOF | ||
"${a}": { | ||
"hash": "$HASH", | ||
"url": "$URL", | ||
"version": "$VERSION", | ||
"description": $DESCRIPTION, | ||
"homepage": "$HOMEPAGE" | ||
}, | ||
EOF | ||
APPS=`cat nextcloud-apps.json | jq -r 'keys|.[]' | sed -z 's/\n/,/g;s/,$/\n/'` | ||
Ma27 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
# If we can't find the app, then don't try to process it. | ||
else | ||
true | ||
fi | ||
done | ||
# clean up by removing last trailing comma | ||
sed -i '$s/,$//' "$MAJOR_FILE".tmp | ||
# Add final closing bracket | ||
echo '}' >>"$MAJOR_FILE".tmp | ||
# Beautify file | ||
jq '.' "$MAJOR_FILE".tmp >"$MAJOR_FILE" | ||
# Remove the temporary files | ||
rm "$APPS_PER_VERSION" | ||
rm "$MAJOR_FILE".tmp | ||
rm "$MAJOR_FILE".bak | ||
done | ||
nc4nix -apps $APPS | ||
rm *.log | ||
Ma27 marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is a non-breaking change until we set
by default. I suggest we do so, accompanied by release notes, before NixOS 24.11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good 👍
Do you want to file a PR for that?