protoc-gen-go-hashpb: init at 0.3.1 #331450
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urandom2
force-pushed
the
protoc-gen-go-hashpb
branch
from
d8807b9 to
dc274cf
Compare
urandom2
force-pushed
the
protoc-gen-go-hashpb
branch
from
dc274cf to
b64185b
Compare
ofborg
bot
added
8.has: package (new)
FliegendeWurst
approved these changes
Oct 31, 2024
wegank
added
the
12.approvals: 1
FliegendeWurst
requested changes
Dec 6, 2024
Comment on lines
+11
to
+14
| src = fetchFromGitHub { | ||
| owner = "cerbos"; | ||
| repo = pname; | ||
| rev = "v${version}"; |
There was a problem hiding this comment.
Suggested change
| src = fetchFromGitHub { | |
| owner = "cerbos"; | |
| repo = pname; | |
| rev = "v${version}"; | |
| src = fetchFromGitHub { | |
| owner = "cerbos"; | |
| repo = "protoc-gen-go-hashpb"; | |
| tag = "v${version}"; |
| subPackages = [ "." ]; | ||
|
|
||
| meta = { | ||
| description = "A protobuf plugin to generate hash functions for messages"; |
There was a problem hiding this comment.
Suggested change
| description = "A protobuf plugin to generate hash functions for messages"; | |
| description = "Protobuf plugin to generate hash functions for messages"; |
wegank
removed
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #290460
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.