Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdenv/darwin/make-bootstrap-tools.nix: add libcodedirectory.1.dylib #331145

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

reckenrode
Copy link
Contributor

Description of changes

libcodedirectory.1.dylib is needed by ld64 and several tools from cctools such as codesign_allocate.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

`libcodedirectory.1.dylib` is needed by ld64 and several tools from cctools such as `codesign_allocate`.
@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Jul 30, 2024
@vcunat vcunat added the 1.severity: channel blocker Blocks a channel label Jul 30, 2024
@vcunat vcunat merged commit 807c950 into NixOS:master Jul 30, 2024
10 of 11 checks passed
@vcunat
Copy link
Member

vcunat commented Jul 30, 2024

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: channel blocker Blocks a channel 6.topic: stdenv Standard environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants