Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql-workbench: fix build #331127

Merged
merged 1 commit into from
Jul 30, 2024
Merged

mysql-workbench: fix build #331127

merged 1 commit into from
Jul 30, 2024

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Jul 30, 2024

Description of changes

Resolves #331121

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@khaneliman
Copy link
Contributor Author

Result of nixpkgs-review pr 331127 run on x86_64-linux 1

1 package built:
  • mysql-workbench

@ofborg ofborg bot requested a review from TomaSajt July 30, 2024 20:25
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 30, 2024
@TomaSajt
Copy link
Contributor

Thanks for tracking this down :)

Copy link
Contributor

@superherointj superherointj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Master is indeed failing. And this fixes it.

@superherointj superherointj merged commit 3f40c5c into NixOS:master Jul 30, 2024
32 of 34 checks passed
@kirillrdy
Copy link
Member

similar issue with postgres #331166

although will have to go through staging :-(

@khaneliman khaneliman deleted the mysql branch July 30, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: mysql-workbench-8.0.38
4 participants