Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs2nix: bump #331025

Merged
merged 1 commit into from
Jul 30, 2024
Merged

emacs2nix: bump #331025

merged 1 commit into from
Jul 30, 2024

Conversation

jian-lin
Copy link
Contributor

@jian-lin jian-lin commented Jul 30, 2024

This bump includes two1 fixes2.

Description of changes

I tested it to update elpa, elpa-devel and nongnu and it works well. I do not include those bumps into this PR because I do not want to go through the staging cycle.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jian-lin jian-lin requested a review from adisbladis as a code owner July 30, 2024 07:10
@jian-lin jian-lin requested a review from AndersonTorres July 30, 2024 07:10
@github-actions github-actions bot added the 6.topic: emacs Text editor label Jul 30, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 30, 2024
@jian-lin
Copy link
Contributor Author

Let's merge it since the changes of emacs2nix have been reviewed by adisbladis.

@jian-lin jian-lin merged commit 38f4cf0 into NixOS:master Jul 30, 2024
30 checks passed
@jian-lin jian-lin deleted the pr/bump-emacs2nix branch July 30, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: emacs Text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant