haskell.compiler.ghc8107Binary: fix build on staging-next #330559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reckenrode
requested review from
sternenseemann,
maralorn and
ncfavier
as code owners
13 tasks
reckenrode
force-pushed
the
ghc-bindist-fixes
branch
from
0eb6c60 to
e90c72f
Compare
…4-darwin Because the binaries in the bindist lack the linker-signed flag in their signatures, `install_name_tool` will invalidate them when it processes them. Repair the signatures using `rcodesign`, which can also set the linker-signed flag when it replaces the signatures. Having the flag present causes future invocations of `install_name_tool` and `strip` on them to update the signatures.
reckenrode
force-pushed
the
ghc-bindist-fixes
branch
from
e90c72f to
1015887
Compare
13 tasks
reckenrode
changed the title
|
I moved the GHC 9.8 bootstrap fix to #330560. |
ofborg
bot
requested review from
expipiplus1,
cdepillabout,
domenkozar and
prusnak
ofborg
bot
added
10.rebuild-darwin: 0
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes build failures on staging-next #328673.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.