Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgs/applications: remove unused arguments #328741

Merged
merged 1 commit into from
Jul 26, 2024
Merged

pkgs/applications: remove unused arguments #328741

merged 1 commit into from
Jul 26, 2024

Conversation

Sigmanificient
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: qt/kde 6.topic: emacs Text editor 6.topic: vim 6.topic: vscode 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab labels Jul 20, 2024
@Sigmanificient Sigmanificient marked this pull request as draft July 20, 2024 20:36
@Sigmanificient Sigmanificient force-pushed the remove-unused-arguments-pkgs-app branch 7 times, most recently from c5d2201 to 843da71 Compare July 21, 2024 06:09
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 21, 2024
@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review July 21, 2024 19:47
@SuperSandro2000
Copy link
Member

Please rebase otherwise LGTM

@Sigmanificient Sigmanificient force-pushed the remove-unused-arguments-pkgs-app branch from 843da71 to b51bad9 Compare July 24, 2024 16:42
@teto teto removed their request for review July 24, 2024 22:14
@Sigmanificient Sigmanificient force-pushed the remove-unused-arguments-pkgs-app branch from b51bad9 to bd9be30 Compare July 26, 2024 01:36
@Sigmanificient Sigmanificient force-pushed the remove-unused-arguments-pkgs-app branch from bd9be30 to 265ca44 Compare July 26, 2024 01:38
@Sigmanificient Sigmanificient force-pushed the remove-unused-arguments-pkgs-app branch from 265ca44 to 2ee703d Compare July 26, 2024 09:36
@Aleksanaa Aleksanaa merged commit 84a53ad into NixOS:master Jul 26, 2024
21 checks passed
@Sigmanificient Sigmanificient deleted the remove-unused-arguments-pkgs-app branch July 26, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigmaSquadron SigmaSquadron SigmaSquadron approved these changes

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

@figsoda figsoda Awaiting requested review from figsoda

@adisbladis adisbladis Awaiting requested review from adisbladis

@K900 K900 Awaiting requested review from K900

@NickCao NickCao Awaiting requested review from NickCao

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@ttuegel ttuegel Awaiting requested review from ttuegel

@emilylange emilylange Awaiting requested review from emilylange

Assignees
No one assigned
Labels
6.topic: emacs Text editor 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: qt/kde 6.topic: vim 6.topic: vscode 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sigmanificient @SuperSandro2000 @SigmaSquadron @Aleksanaa