Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgs/by-name: remove unused arguments #328726

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jul 20, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 20, 2024
@adamcstephens
Copy link
Contributor

Without automated linting, isn't it inevitable for these problems to reoccur?

@Sigmanificient
Copy link
Member Author

Without automated linting, isn't it inevitable for these problems to reoccur?

Well someone commented about adding a GitHub action #313981 (comment), but I am not sure how to setup up properly to nixpkgs standards, and I discussed with @wegank about it who told me:

I'd consider making a workflow for deadnix a much less important thing
Unless deadnix becomes official (like nixfmt-rfc-style) or is proven to be error-free

@Sigmanificient Sigmanificient added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 24, 2024
@Aleksanaa Aleksanaa added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 26, 2024
@Sigmanificient Sigmanificient force-pushed the remove-unused-args-by-name branch from 9cb0d40 to 6845a70 Compare July 26, 2024 08:04
@Sigmanificient Sigmanificient removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 26, 2024
@Sigmanificient Sigmanificient force-pushed the remove-unused-args-by-name branch from 6845a70 to 61fe0c0 Compare July 26, 2024 08:11
@Aleksanaa Aleksanaa merged commit 1aeb5f2 into NixOS:master Jul 26, 2024
21 checks passed
@Sigmanificient Sigmanificient deleted the remove-unused-args-by-name branch July 26, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants