Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxml2: Fix XInclude failure handling #328261

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Jul 18, 2024

Description of changes

This fixes colord api docs build with libxml2 2.13.

Follow up to #326637

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Built colord after paring it down and rebasing this PR onto nixos-unstable
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This fixes colord api docs build with libxml2 2.13.
@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild label Jul 18, 2024
@ofborg ofborg bot requested a review from edolstra July 18, 2024 22:22
@vcunat vcunat merged commit 85270a1 into NixOS:staging Jul 20, 2024
33 of 34 checks passed
@jtojnar jtojnar deleted the libxml2-backports branch July 20, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants