Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

element-desktop: 1.11.70 -> 1.11.71 #328079

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

Guanran928
Copy link
Contributor

@Guanran928 Guanran928 commented Jul 18, 2024

Description of changes

https://github.com/element-hq/element-desktop/releases/tag/v1.11.71

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Guanran928 Guanran928 added the backport release-24.05 Backport PR automatically label Jul 18, 2024
Copy link
Member

@ryand56 ryand56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 328079 run on x86_64-linux 1

3 packages built:
  • element-desktop
  • element-desktop-wayland
  • element-web (element-web-unwrapped)

@Guanran928 Guanran928 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 18, 2024
@Guanran928
Copy link
Contributor Author

Result of nixpkgs-review pr 328079 run on x86_64-linux 1

3 packages built:
  • element-desktop
  • element-desktop-wayland
  • element-web (element-web-unwrapped)

@marcusramberg marcusramberg merged commit d3b0a82 into NixOS:master Jul 18, 2024
32 of 34 checks passed
Copy link
Contributor

Successfully created backport PR for release-24.05:

@pkern
Copy link
Contributor

pkern commented Jul 28, 2024

I'll note that this and #328152 broke the use of Firefox ESR 115 with Element web (i.e. subject to element-hq/element-web#27684). element-hq/element-web#27803 adds a polyfill to restore compatibility.

@Guanran928 Guanran928 deleted the element-desktop branch July 30, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.05 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants