Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs.pkgs.mind-wave: remove #327895

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

jian-lin
Copy link
Contributor

@jian-lin jian-lin commented Jul 17, 2024

  • This package cannot be accessed normally because it does not add an entry to the manual-packages.nix file. Since there is no issues raised about this, probably no one uses this package.

  • The quality of this package is not on par with other packages.

    • about nix expression:
      • Its passthru.updateScript does not work.
      • It introduces an elisp dependency markdown-mode wrongly.
      • It uses pkgs. - It has a redundant parameter substituteAll.
      • It contains a huge block of unneeded comments.
    • about functionality:
      • It does not work out of the box because it does not patch mind-wave-python-command.

cc @yuzukicat

related: #278925

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

- This package cannot be accessed normally because it does not add an
entry to the manual-packages.nix file.  Since there is no issues
raised about this, probably no one uses this package.

- The quality of this package is not on par with other packages.
  - about nix expression:
    - Its passthru.updateScript does not work.
    - It introduces an elisp dependency markdown-mode wrongly.
    - It uses pkgs.
    - It has a redundant parameter substituteAll.
    - It contains a huge block of unneeded comments.
  - about functionality:
    - It does not work out of the box because it does not patch
    mind-wave-python-command.
@jian-lin jian-lin requested a review from adisbladis as a code owner July 17, 2024 11:47
@github-actions github-actions bot added the 6.topic: emacs Text editor label Jul 17, 2024
@jian-lin jian-lin requested a review from AndersonTorres July 17, 2024 11:50
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 17, 2024
@jian-lin jian-lin merged commit 399abfa into NixOS:master Jul 17, 2024
23 checks passed
@jian-lin jian-lin deleted the pr/remove-mind-wave branch July 17, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: emacs Text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants