stp: fix setuptools dependency #327037
Merged
stp: fix setuptools dependency #327037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
13 tasks
McSinyx
reviewed
Jul 15, 2024
numinit
force-pushed
the
stp-fix-setuptools
branch
4 times, most recently
from
924c942 to
7fdd39a
Compare
numinit
force-pushed
the
stp-fix-setuptools
branch
from
7fdd39a to
eba4ac1
Compare
McSinyx
suggested changes
Jul 15, 2024
There was a problem hiding this comment.
The Python package seems to need stp/stp#455 to work:
>>> import stp
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/nix/store/n09cfnslrhcs2rrxsgj3hssz94k320pf-stp-2.3.3/lib/python3.12/site-packages/stp/__init__.py", line 23, in <module>
from .stp import Expr, Solver, stp, add, bitvec, bitvecs, check, model
File "/nix/store/n09cfnslrhcs2rrxsgj3hssz94k320pf-stp-2.3.3/lib/python3.12/site-packages/stp/stp.py", line 45, in <module>
from library_path import PATHS
|
Thanks. I was going to add a checkPhase/installCheckPhase when I bump the version so we catch things like this. |
This is fully removed in Python 3.12 and should be replaced with
sysconfig.get_path('purelib').
numinit
force-pushed
the
stp-fix-setuptools
branch
from
eba4ac1 to
6be4dbd
Compare
|
Thanks Sandro, I appreciate the review. |
SuperSandro2000
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixing breakage due to setuptools removal in #320924.
Partially resolves #326927.
Update to next stp version will be in a separate PR.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.