Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: sha256 -> hash for fetchCrate #326859

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Jul 13, 2024

Only causes a rebuild of rure and its dependents, as that's the only package that actually gets updated here.

Part of #325892

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Aleksanaa
Copy link
Member

Could you split rure change into another commit?

@pyrox0 pyrox0 force-pushed the fetchcrate-no-sha256 branch from deeb2a1 to 504c368 Compare July 14, 2024 17:46
pyrox0 added 2 commits July 14, 2024 13:48
Should cause no rebuilds, as this is just updating attributes.
@pyrox0 pyrox0 force-pushed the fetchcrate-no-sha256 branch from 504c368 to 7f9dcdb Compare July 14, 2024 17:48
@pyrox0
Copy link
Member Author

pyrox0 commented Jul 14, 2024

Split out, and merge conflicts are fixed.

@Aleksanaa Aleksanaa merged commit bfa89ca into NixOS:master Jul 15, 2024
24 of 26 checks passed
@pyrox0 pyrox0 deleted the fetchcrate-no-sha256 branch August 4, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants