gns3-gui: fix build by pinning python to 3.11, update sip #326646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg build gns3-gui |
13 tasks
ofborg
bot
added
8.has: package (new)
|
@ofborg build gns3-gui gns3-gui.passthru.tests |
vifino
approved these changes
Jul 18, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4310 |
milahu
added a commit
to milahu/nur-packages
that referenced
this pull request
Oct 23, 2024
revert d203ca98569fca1f9a0641a30cd9841b3b646c0a from NixOS/nixpkgs#326646 which created derivations with 2 python versions (3.11 + 3.12) which breaks the import of rpds: ModuleNotFoundError: No module named 'rpds.rpds' python-jsonschema/jsonschema#1175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #326245
Like #326211, this is just a quick fix and we should ideally make it work with Python 3.12.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.