Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open-webui: 0.3.7 -> 0.3.8 #326337

Merged
merged 3 commits into from
Jul 12, 2024
Merged

open-webui: 0.3.7 -> 0.3.8 #326337

merged 3 commits into from
Jul 12, 2024

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Jul 11, 2024 •
edited
Loading

diff: https://github.com/open-webui/open-webui/compare/v0.3.7..v0.3.8
changelog: https://github.com/open-webui/open-webui/releases/tag/v0.3.8

  • Fix python3Packages.ctranslate2, remove Tensorflow related tests momentarily.
  • Fix python3Packages.langchain-community, remove duckdb-engine related tests momentarily

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@drupol drupol force-pushed the open-webui/bump/0-3-8 branch 2 times, most recently from 768bc1b to 659aebc Compare July 11, 2024 18:22
@ofborg ofborg bot requested a review from shivaraj-bh July 11, 2024 19:05
@drupol
Copy link
Contributor Author

drupol commented Jul 11, 2024

The build on Python 3.11 is failing:

-- Performing Test COMPILER_SUPPORTS_NO_AVX256_SPLIT
/build/source
Finished executing pypaBuildPhase
Running phase: pythonRuntimeDepsCheckHook
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for chromadb-0.5.3-py3-none-any.whl
  - chroma-hnswlib==0.7.3 not satisfied by version 0.7.5
error: builder for '/nix/store/0svm9gd69lggnb56k1vwacgspc8vgw9p-python3.11-chromadb-0.5.3.drv' failed with exit code 1;
       last 10 log lines:
       > evaling implicit 'postBuild' string hook
       > /build/source/dist /build/source
       > Unpacking to: unpacked/chromadb-0.5.3...OK
       > Repacking wheel as ./chromadb-0.5.3-py3-none-any.whl...OK
       > /build/source
       > Finished executing pypaBuildPhase
       > Running phase: pythonRuntimeDepsCheckHook
       > Executing pythonRuntimeDepsCheck
       > Checking runtime dependencies for chromadb-0.5.3-py3-none-any.whl
       >   - chroma-hnswlib==0.7.3 not satisfied by version 0.7.5
       For full logs, run 'nix-store -l /nix/store/0svm9gd69lggnb56k1vwacgspc8vgw9p-python3.11-chromadb-0.5.3.drv'.
error: 1 dependencies of derivation '/nix/store/r7dxikz28vb08y6wh27fa03x6xb1rzg3-python3.11-langchain-chroma-0.2.9.drv' failed to build
-- Performing Test COMPILER_SUPPORTS_NO_AVX256_SPLIT - Success
-- Using ATen parallel backend: OMP
disabling CUDA because USE_CUDA is set false
CMake Deprecation Warning at third_party/sleef/CMakeLists.txt:87 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

@drupol drupol marked this pull request as ready for review July 11, 2024 20:57
@ofborg ofborg bot requested a review from fabaff July 11, 2024 20:58
@drupol drupol force-pushed the open-webui/bump/0-3-8 branch from d4637c4 to e5a6e08 Compare July 11, 2024 21:09
@Tungsten842
Copy link
Member

I believe that fixing #326348 would be a better idea than downgrading python. Since tensorflow is only used for ctranslate2 tests, simply disabling them would fix the issue.

@drupol

This comment was marked as resolved.

Sign in to view
@drupol drupol force-pushed the open-webui/bump/0-3-8 branch from e5a6e08 to 8bfb269 Compare July 11, 2024 21:42
@drupol
Copy link
Contributor Author

drupol commented Jul 11, 2024

@ofborg build open-webui python3Packages.ctranslate2 python311Packages.chromadb python3Packages.chromadb

@drupol drupol mentioned this pull request Jul 11, 2024
Closed
@ofborg ofborg bot requested a review from mweinelt July 11, 2024 22:13
@drupol drupol mentioned this pull request Jul 12, 2024
Merged
13 tasks
@Tungsten842
Copy link
Member

Result of nixpkgs-review pr 326337 run on x86_64-linux 1

12 packages marked as broken and skipped:
  • open-webui
  • open-webui.dist
  • python311Packages.llama-index
  • python311Packages.llama-index-cli
  • python311Packages.llama-index-cli.dist
  • python311Packages.llama-index-vector-stores-chroma
  • python311Packages.llama-index-vector-stores-chroma.dist
  • python311Packages.llama-index.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
  • whisper-ctranslate2
  • whisper-ctranslate2.dist
32 packages built:
  • python311Packages.argos-translate-files
  • python311Packages.argos-translate-files.dist
  • python311Packages.argostranslate
  • python311Packages.argostranslate.dist
  • python311Packages.chromadb
  • python311Packages.chromadb.dist
  • python311Packages.ctranslate2
  • python311Packages.ctranslate2.dist
  • python311Packages.faster-whisper
  • python311Packages.faster-whisper.dist
  • python311Packages.langchain-chroma
  • python311Packages.langchain-chroma.dist
  • python311Packages.libretranslate
  • python311Packages.libretranslate.dist
  • python311Packages.translatehtml
  • python311Packages.translatehtml.dist
  • python312Packages.argos-translate-files
  • python312Packages.argos-translate-files.dist
  • python312Packages.argostranslate
  • python312Packages.argostranslate.dist
  • python312Packages.chromadb
  • python312Packages.chromadb.dist
  • python312Packages.ctranslate2
  • python312Packages.ctranslate2.dist
  • python312Packages.faster-whisper
  • python312Packages.faster-whisper.dist
  • python312Packages.langchain-chroma
  • python312Packages.langchain-chroma.dist
  • python312Packages.translatehtml
  • python312Packages.translatehtml.dist
  • wyoming-faster-whisper
  • wyoming-faster-whisper.dist

@drupol
Copy link
Contributor Author

drupol commented Jul 12, 2024 •
edited
Loading

open-webui shouldn't be broken any more, I can build it with ofborg

@Tungsten842
Copy link
Member

open-webui shouldn't be broken any more, I can build it with ofborg

I am getting this:

nix build https://github.com/NixOS/nixpkgs/archive/refs/heads/open-webui/bump/0-3-8.zip#open-webui
error: Package ‘python3.12-wasmer-1.2.0’ in /nix/store/7iqf3axmyzw262hx7y9awfmf6015j2jb-source/pkgs/development/python-modules/wasmer/default.nix:78 is marked as broken, refusing to evaluate.

@Tungsten842
Copy link
Member

Tungsten842 commented Jul 12, 2024 •
edited
Loading

I believe that removing duckdb-engine from langchain-community when using python 3.12 should be enough to fix it. It seems to be used only for tests.

@drupol drupol force-pushed the open-webui/bump/0-3-8 branch from 7ac12b5 to 8bfb269 Compare July 12, 2024 08:48
@drupol
Copy link
Contributor Author

drupol commented Jul 12, 2024 •
edited
Loading

@ofborg build open-webui python3Packages.ctranslate2 python311Packages.chromadb python3Packages.chromadb python3Packages.langchain-community

@drupol
Copy link
Contributor Author

drupol commented Jul 12, 2024

Thank you @Tungsten842 !!!!

@drupol drupol requested a review from GaetanLepage July 12, 2024 09:30
@ofborg ofborg bot requested a review from natsukium July 12, 2024 09:47
@Tungsten842
Copy link
Member

Result of nixpkgs-review pr 326337 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • whisper-ctranslate2
  • whisper-ctranslate2.dist
4 packages failed to build:
  • python311Packages.langchain-chroma
  • python311Packages.langchain-chroma.dist
  • python311Packages.langchain-community
  • python311Packages.langchain-community.dist
34 packages built:
  • open-webui
  • open-webui.dist
  • python311Packages.argos-translate-files
  • python311Packages.argos-translate-files.dist
  • python311Packages.argostranslate
  • python311Packages.argostranslate.dist
  • python311Packages.chromadb
  • python311Packages.chromadb.dist
  • python311Packages.ctranslate2
  • python311Packages.ctranslate2.dist
  • python311Packages.faster-whisper
  • python311Packages.faster-whisper.dist
  • python311Packages.libretranslate
  • python311Packages.libretranslate.dist
  • python311Packages.translatehtml
  • python311Packages.translatehtml.dist
  • python312Packages.argos-translate-files
  • python312Packages.argos-translate-files.dist
  • python312Packages.argostranslate
  • python312Packages.argostranslate.dist
  • python312Packages.chromadb
  • python312Packages.chromadb.dist
  • python312Packages.ctranslate2
  • python312Packages.ctranslate2.dist
  • python312Packages.faster-whisper
  • python312Packages.faster-whisper.dist
  • python312Packages.langchain-chroma
  • python312Packages.langchain-chroma.dist
  • python312Packages.langchain-community
  • python312Packages.langchain-community.dist
  • python312Packages.translatehtml
  • python312Packages.translatehtml.dist
  • wyoming-faster-whisper
  • wyoming-faster-whisper.dist

@drupol
Copy link
Contributor Author

drupol commented Jul 12, 2024

I can build python311Packages.langchain-chroma successfully locally.

image

@drupol drupol force-pushed the open-webui/bump/0-3-8 branch from ca2faec to 076063a Compare July 12, 2024 10:34
@Tungsten842
Copy link
Member

Result of nixpkgs-review pr 326337 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • whisper-ctranslate2
  • whisper-ctranslate2.dist
30 packages built:
  • open-webui
  • open-webui.dist
  • python311Packages.argos-translate-files
  • python311Packages.argos-translate-files.dist
  • python311Packages.argostranslate
  • python311Packages.argostranslate.dist
  • python311Packages.ctranslate2
  • python311Packages.ctranslate2.dist
  • python311Packages.faster-whisper
  • python311Packages.faster-whisper.dist
  • python311Packages.langchain-community
  • python311Packages.langchain-community.dist
  • python311Packages.libretranslate
  • python311Packages.libretranslate.dist
  • python311Packages.translatehtml
  • python311Packages.translatehtml.dist
  • python312Packages.argos-translate-files
  • python312Packages.argos-translate-files.dist
  • python312Packages.argostranslate
  • python312Packages.argostranslate.dist
  • python312Packages.ctranslate2
  • python312Packages.ctranslate2.dist
  • python312Packages.faster-whisper
  • python312Packages.faster-whisper.dist
  • python312Packages.langchain-community
  • python312Packages.langchain-community.dist
  • python312Packages.translatehtml
  • python312Packages.translatehtml.dist
  • wyoming-faster-whisper
  • wyoming-faster-whisper.dist

@drupol drupol requested a review from GaetanLepage July 12, 2024 12:22
GaetanLepage
GaetanLepage approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@drupol drupol merged commit e23552c into master Jul 12, 2024
26 of 28 checks passed
@drupol drupol deleted the open-webui/bump/0-3-8 branch July 12, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@Tungsten842 Tungsten842 Tungsten842 approved these changes

@shivaraj-bh shivaraj-bh Awaiting requested review from shivaraj-bh

@fabaff fabaff Awaiting requested review from fabaff

@mweinelt mweinelt Awaiting requested review from mweinelt

@natsukium natsukium Awaiting requested review from natsukium

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drupol @Tungsten842 @GaetanLepage