Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

itsycal: rfc format; itsycal: add meta.changelog; ityscal: 0.15.3 -> 0.15.4 #326327

Merged
merged 3 commits into from
Jul 12, 2024
Merged

itsycal: rfc format; itsycal: add meta.changelog; ityscal: 0.15.3 -> 0.15.4 #326327

merged 3 commits into from
Jul 12, 2024

Conversation

DontEatOreo
Copy link
Member

Description of changes

Diff: sfsam/Itsycal@0.15.3...0.15.4

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 11, 2024
@DontEatOreo
Copy link
Member Author

This seems like Ofborg issue... https://gist.github.com/GrahamcOfBorg/461ab2c2b5a85e282d48a1b10bf9d7e6

@GrahamcOfBorg eval

@DontEatOreo
Copy link
Member Author

Result of nixpkgs-review pr 326327 run on aarch64-darwin 1

1 package built:
  • itsycal

@DontEatOreo DontEatOreo requested a review from JohnRTitor July 12, 2024 18:14
@JohnRTitor JohnRTitor merged commit 9afce28 into NixOS:master Jul 12, 2024
28 of 30 checks passed
@DontEatOreo DontEatOreo deleted the update-ityscal branch July 12, 2024 18:52
@DontEatOreo DontEatOreo added the backport release-24.05 Backport PR automatically label Jul 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Jul 12, 2024
Merged
1 task
shahinism pushed a commit to shahinism/nixpkgs that referenced this pull request Jul 15, 2024
@DontEatOreo @shahinism
itsycal: rfc format; itsycal: add meta.changelog; ityscal: 0.15.3 -> …
6a29e89 
…0.15.4 (NixOS#326327)

* itsycal: rfc format

* itsycal: add meta.changelog

* ityscal: 0.15.3 -> 0.15.4

Diff: sfsam/Itsycal@0.15.3...0.15.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnRTitor JohnRTitor Awaiting requested review from JohnRTitor

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DontEatOreo @JohnRTitor